[ENH] Implement Multivariatenormal #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshvirSandhu
requested review from
felipeangelimvieira,
fkiraly and
SaiRevanth25
as code owners
VascoSch92
reviewed
Feb 8, 2025
|
|
||
| Parameters | ||
| ---------- | ||
| mean : array_like, default: ``[0]`` |
There was a problem hiding this comment.
Suggested change
| mean : array_like, default: ``[0]`` | |
| mean : array_like, default = ``[0]`` |
you are using another style at the lines 35/36. Which is the correct one?
Other question: From the implementation, it seems that mean has not a default value. Or ?
There was a problem hiding this comment.
Yes, it should be = instead of :
fkiraly
requested changes
Feb 12, 2025
|
@fkiraly Just wanted to confirm what methods have to implemented using |
can you kindly rephrase? this sentence seems to be missing parts. |
|
Some of the distributions (like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#22
What does this implement/fix? Explain your changes.
Implement
MultiVariate_Normalby interfacingscipy.stats.multivariate_normalDoes your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Not sure if the
_tagsvariable is right for this distributionDid you add any tests for the change?
No
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference